When processing an archive file, multiple object files may have sections
with the same name. Have the dump_sections() and dump_section_contents()
commands concatenate sections with the same name across object files.
Bug: b/254925614
Change-Id: I03dcd9c801afb8c944229d53570427d921327243
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/116211
Reviewed-by: Anthony Stange <stange@google.com>
Reviewed-by: Armando Montanez <amontanez@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
Pigweed-Auto-Submit: Wyatt Hepler <hepler@google.com>
Some port numbers added a zero in the middle, making them larger than
expected. This puts those ports back into the intended range.
Change-Id: I1383ee9b3d26e0ac585e7e3caccd57dbc9cb7dbb
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/116253
Pigweed-Auto-Submit: Armando Montanez <amontanez@google.com>
Reviewed-by: Alexei Frolov <frolv@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
Rename Hci to "Controller".
Add Controller::GetFeatures() method that returns a bitmask of
features supported by the controller.
Add Controller::EncodeVendorCommand() method and associated types.
Add Controller::Initialize() method to enable implementations
to run initialization code and the Bluetooth stack to be
notified of errors.
Rename DataCallback to DataFunction to more accurately describe
the type it is aliasing.
Add support for sending/receiving SCO data to Controller.
Change-Id: Iafbac262ee5d1a920508da97b58e8d06aab1c15b
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/111751
Commit-Queue: Ben Lawson <benlawson@google.com>
Reviewed-by: Erik Gilling <konkers@google.com>
Reviewed-by: Wyatt Hepler <hepler@google.com>
Reviewed-by: Marie Janssen <jamuraa@google.com>
Adds a LogPane option to view logs in a web browser.
Change-Id: I606a7d8a20ed69632a069e168e8e6949eb22109b
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/109714
Reviewed-by: Asad Memon <asadmemon@google.com>
Commit-Queue: Anthony DiGirolamo <tonymd@google.com>
Allow the pw::StringBuilder class to use a pw::InlineString as its
buffer.
Change-Id: If75169d6a4839b19187e21e01e00ef5d23adcc12
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/103365
Pigweed-Auto-Submit: Wyatt Hepler <hepler@google.com>
Commit-Queue: Wyatt Hepler <hepler@google.com>
Reviewed-by: Armando Montanez <amontanez@google.com>
The tests include pw_thread_stl headers. If the host toolchain uses a
different thread backend it causes gn check errors.
Change-Id: I3f97c9b17cd5551daa7142e3970b55b5a80d262c
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/116151
Reviewed-by: Armando Montanez <amontanez@google.com>
Commit-Queue: Yvonne Yip <ykyyip@google.com>
Adds integration tests that specifically request transfers are performed
using the v1 protocol to verify v1 protocol compatibility across the
same client/server version.
Cq-Include-Trybots: luci.pigweed.try:pigweed-integration-transfer
Change-Id: Ifa4b304f88e3790f168c8766ea63cec17212458e
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/114133
Pigweed-Auto-Submit: Armando Montanez <amontanez@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
Reviewed-by: Ted Pudlik <tpudlik@google.com>
This updates the `pw bloat` command to allow specifying a base binary to
run a size diff report against.
Change-Id: I1219679c3f98a5cec1d8992a626ce54fc624da3f
Requires: pigweed-internal:32581
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/112318
Reviewed-by: Armando Montanez <amontanez@google.com>
Commit-Queue: Alexei Frolov <frolv@google.com>
Added a handler function for `generate-key` which calls
the keys.py module and handles IO for successful key generation
Bug: 254524996
Change-Id: I1c61c3f7a46e80d6238d218d86bfc623c0cbdab3
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/116011
Commit-Queue: Eashan Singh <eashansingh@google.com>
Reviewed-by: Ali Zhang <alizhang@google.com>
This allows buildifier to be included without pulling in bazel, but also
for projects using bazel to always get buildifier.
Bug: b/254510918
Change-Id: Iabc41a2b61ccb4cc177e6d5c66884de4a322d613
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/116013
Pigweed-Auto-Submit: Rob Mohr <mohrr@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
Reviewed-by: Max Koopman <koopman@google.com>
We already depend on boringssl in the gn build, so there's nothing new
here. This is required to get the targets in pw_software_update that
depend on boringssl to build.
Change-Id: I156275abe145b42d0e973ff9614ab5c230ddb258
Signed-off-by: Nathaniel Brough <nathaniel.brough@gmail.com>
Bug: 232427554
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/91051
Reviewed-by: Ali Zhang <alizhang@google.com>
Reviewed-by: Keir Mierle <keir@google.com>
Commit-Queue: Ted Pudlik <tpudlik@google.com>
Bumps all stm32cube_xx configurations to the latest version from ST.
The immediate motivation is access to ST's significantly improved/fixed
Ethernet HAL in recent versions.
Change-Id: Ifbe0aa57f65830fc86428f4474c5213d87e4f9c0
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/115872
Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
Reviewed-by: Armando Montanez <amontanez@google.com>
Pigweed-Auto-Submit: Armando Montanez <amontanez@google.com>
No longer include bazel by default in downstream projects.
Bug: b/254510918
Change-Id: I507161bc1226d559cb49637b502a80765433f709
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/116010
Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
Pigweed-Auto-Submit: Rob Mohr <mohrr@google.com>
Reviewed-by: Erik Gilling <konkers@google.com>
Reduce the CIPD packages that are pulled in by default for downstream
projects. Break out non-essential packages into separate files that can
be included or not in downstream projects.
Bug: b/254510918
Change-Id: I98603ba21726dd1320eae6c77122c663e5d38f11
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/115531
Reviewed-by: Ewout van Bekkum <ewout@google.com>
Reviewed-by: Chad Norvell <chadnorvell@google.com>
Commit-Queue: Rob Mohr <mohrr@google.com>
IntrusivePtr is similar to std::shared_ptr, but has three main
differences:
1. It requires pointed-at object to do the reference counting (can be
achieved by subclassing RefCounted).
2. Control block is always atomic.
3. No weak_ptr support.
Change-Id: I4fbb69ea875b1f8d84d05d749f7b79a88f8bbcdc
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/115252
Pigweed-Auto-Submit: Dennis Kormalev <denk@google.com>
Commit-Queue: Dennis Kormalev <denk@google.com>
Reviewed-by: Wyatt Hepler <hepler@google.com>
Support specifying a container type and a #include for it for pw_rpc
endpoints to use. The default type is std::vector, but any compatible
type may be used. This container is only used when dynamic allocation is
enabled.
Fixes: b/243403830
Change-Id: Ib41431fea10d7b7700bc82dee4ba1d80e6d16bc9
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/115089
Reviewed-by: Alexei Frolov <frolv@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
Pigweed-Auto-Submit: Wyatt Hepler <hepler@google.com>
This module will contain IntrusivePtr which can be used instead of the
std::shared_ptr construct in cases when memory allocation is still
allowed but code is compiled with toolchains that have threading
disabled (which results in non-atomic control blocks in
std::shared_ptr).
Change-Id: Ib06b4421dae7b90df6c665e7dfd750584ae90296
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/115251
Reviewed-by: Wyatt Hepler <hepler@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
Pigweed-Auto-Submit: Dennis Kormalev <denk@google.com>
This argument may be used when proto definitions are generated by
other targets.
Update related docs.
Change-Id: I96e77efb6c5060e96cf853ed52025e23435f4cb7
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/115810
Commit-Queue: Dmitry Kotov <dkotov@google.com>
Reviewed-by: Wyatt Hepler <hepler@google.com>
The proto enum translations were already declared explicitly as
uint32_t. Declare the proto fields list enum classes to also use
uint32_t, so that users can feel confident about casting to underlying
type when using a checked field number.
Update docs to match that fact that the enum classes are not using the
default underlying type of `int`.
Change-Id: I212b48a851990931fa2533c6b9273585da5c1c3e
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/114850
Commit-Queue: Anqi Dong <anqid@google.com>
Reviewed-by: Alexei Frolov <frolv@google.com>
This adds a command to the Pigweed CLI which can be used to run size
reports on binaries without having to go through the GN build.
The command initially supports single binary size reports on ELF files
which are linked using pw_bloat memory region symbols. Additional data
sources can be specified to be displayed hierarchically under the root
memoryregions.
Example usage (no child data sources):
$ pw bloat out/docs/obj/pw_result/size_report/bin/ladder_and_then.elf
▒█████▄ █▓ ▄███▒ ▒█ ▒█ ░▓████▒ ░▓████▒ ▒▓████▄
▒█░ █░ ░█▒ ██▒ ▀█▒ ▒█░ █ ▒█ ▒█ ▀ ▒█ ▀ ▒█ ▀█▌
▒█▄▄▄█░ ░█▒ █▓░ ▄▄░ ▒█░ █ ▒█ ▒███ ▒███ ░█ █▌
▒█▀ ░█░ ▓█ █▓ ░█░ █ ▒█ ▒█ ▄ ▒█ ▄ ░█ ▄█▌
▒█ ░█░ ░▓███▀ ▒█▓▀▓█░ ░▓████▒ ░▓████▒ ▒▓████▀
+----------------------+---------+
| memoryregions | sizes |
+======================+=========+
|FLASH |1,048,064|
|RAM | 196,608|
|VECTOR_TABLE | 512|
+======================+=========+
|Total |1,245,184|
+----------------------+---------+
Change-Id: Icc34a085cc62ce3fcf0697f04aaed50c6d559024
Requires: pigweed-internal:32580
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/112314
Reviewed-by: Armando Montanez <amontanez@google.com>
Reviewed-by: Ewout van Bekkum <ewout@google.com>
Commit-Queue: Alexei Frolov <frolv@google.com>
Add empty CIPD files for compatibility. These files will be populated in
a follow-up commit, but adding them now lets downstream projects start
to reference them before they're required.
Bug: b/254510918
Change-Id: Ib2f15b5cee57391d8ec8a883c859d3d4a8203fcf
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/115530
Reviewed-by: Alexei Frolov <frolv@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
Pigweed-Auto-Submit: Rob Mohr <mohrr@google.com>
This file uses limits header but didn't include it before.
Change-Id: Ibb172fa9565df5deda012fb978e6141574532b9e
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/115491
Pigweed-Auto-Submit: Dennis Kormalev <denk@google.com>
Reviewed-by: Rob Mohr <mohrr@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
This file uses limits header but didn't include it before.
Change-Id: I4c727accc31dcbe3f8e79249c71bfe6bfbd07ce6
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/115490
Pigweed-Auto-Submit: Dennis Kormalev <denk@google.com>
Reviewed-by: Rob Mohr <mohrr@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
In several cases we use std::unique_ptr<T> to return an object with RAII
semantics, meaning that some action is needed by the backend to release
the resource when the object goes out of scope. However, using using
std::unique_ptr<T> with the default deleter forces the pw_bluetooth
backend to use new/delete to allocate the T interface implementation.
This patch introduces a RaiiPtr<Api, void (Api::*OnDestroy)()> template
class as an alias of std::unique_ptr with a custom deleter that calls
the Api::OnDestroy parametric method instead of calling "delete". This
template class is used instead of the plain std::unique_ptr when
returning objects from the pw_bluetooth API for the all the "Api"
classes with only pure virtual methods.
In all 5 cases where this pattern was used the abstract class has one
more private pure virtual method (the one used as Api::OnDestroy
parameter) which must be implemented by the backend.
This allows a backend to manage the memory for the returned objects with
something other than new/delete, for example it can return a RaiiPtr to
a std::optional instance or to one of the existing pre-allocated objects
and re-use them when needed. This is particularly useful in cases where
there can only be a fixed small number of objects for the given type,
like in the Scan or AdvertisingParameters case where there is only one
object at a time.
Bug: 250930246
Change-Id: I724ff5135e0f73f5fb74c7fc92abdffa6a9e2d2d
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/113210
Reviewed-by: Wyatt Hepler <hepler@google.com>
Commit-Queue: Alex Deymo <deymo@google.com>
Reviewed-by: Ben Lawson <benlawson@google.com>
Similar to pw::bluetooth::Uuid, this patch makes pw::bluetooth::Address
with helper constructors and methods to convert to and from its binary
representation (6-byte array) and hexadecimal representation, such as
"00:11:22:33:44:55".
Test: Added unittests.
Change-Id: I198a1c1f924f7b7901d56e064a5482c62810e2b4
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/112933
Reviewed-by: Ben Lawson <benlawson@google.com>
Reviewed-by: Marie Janssen <jamuraa@google.com>
Reviewed-by: Wyatt Hepler <hepler@google.com>
Commit-Queue: Alex Deymo <deymo@google.com>
The Bluetooth Core Spec defines 16-bit, 32-bit and full 128-bit
representations of 128-bit UUID values. In several cases the protocol
allows to set a 128-bit value or shorter 16-bit value when using one of
the pre-assigned short 16-bit values.
This patch makes Uuid a class of the same 128-bit size as before but
adds constructors and helper methods to easily handle these
representations as well as printing and parsing human-readable hex
representations of the same.
Test: Added unittests for the new methods.
Change-Id: I93607b58a85eb8a3388a8e2f462aa0245b812c00
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/112932
Reviewed-by: Wyatt Hepler <hepler@google.com>
Reviewed-by: Ben Lawson <benlawson@google.com>
Reviewed-by: Marie Janssen <jamuraa@google.com>
Commit-Queue: Alex Deymo <deymo@google.com>
Moves the MetricWalker to a private header and introduces a virtual
MetricWriter interface to share code common between the pwpb and nanopb
MetricService implementations.
Change-Id: Ibcb173e7ce5cb178a0ec66d07de6c44d1101b3b4
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/101380
Reviewed-by: Keir Mierle <keir@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
Pigweed-Auto-Submit: Armando Montanez <amontanez@google.com>
Add an option to ignore prefixes in keep-sorted blocks, so, for example,
"'CMakeLists.txt'," is placed next to "'*.cmake'," (with
"ignore-prefix='*.,'").
Bug: b/250875082
Change-Id: I2179585708ce950750cdd4cfc475075e181fd2b9
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/115231
Pigweed-Auto-Submit: Rob Mohr <mohrr@google.com>
Reviewed-by: Wyatt Hepler <hepler@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
Some tools and build systems can output multiple compilation databases
instead of just one. Now you can provide either a path to a single file
or a glob to multiple files to process. The result will still be a set
of consistent target-specific compilation databases.
Change-Id: I6fb6e412292ee0a4ec1a5fcbd61c5da3c6e7876f
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/113312
Reviewed-by: Anthony DiGirolamo <tonymd@google.com>
Commit-Queue: Chad Norvell <chadnorvell@google.com>
As with other data passed to the pw_bluetooth backend, the
PersistentData struct needs to use a pw::span instead of pw::Vector so
we can construct it and pass it to the backend.
Drive by spelling fix included.
Change-Id: I800a81ac1da780d0258c54a60d0ebb599e9d3e3f
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/115410
Commit-Queue: Alex Deymo <deymo@google.com>
Reviewed-by: Wyatt Hepler <hepler@google.com>
pw_perf_test now has a backend for which it will use
to time the tested components. This update includes
an implementation with pw_chrono, which will be used
for time-based measurements(nanoseconds).
Change-Id: I9a1bb9cf0964caa4d911a1c7c016bab3a41f1e32
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/113890
Reviewed-by: Wyatt Hepler <hepler@google.com>
Commit-Queue: Brian Barcenas <bbarcenas@google.com>
Reviewed-by: Erik Gilling <konkers@google.com>
pw_doctor currently throws an error during the PW_ROOT check if
the pigweed root is not in its own git repo (or submodule). In my case,
for reasons I'd rather not revisit, pigweed is intentionally vendored
rather than being in a submodule.
This commit adds support for suppressing the anti-vendoring portion of
the PW_ROOT check by setting PW_DISABLE_ROOT_GIT_REPO_CHECK=1 in a
user's bootstrap script.
Change-Id: I5eb8c791fd3444f56103536e7bd4a4a551f711ca
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/115370
Commit-Queue: Rob Mohr <mohrr@google.com>
Reviewed-by: Ted Pudlik <tpudlik@google.com>
Register a new `pw update` command eventually for the
pw_software_update CLI (currently just a skeleton).
Bug: 254524996
Test: Manual invocation of `pw update` works.
Change-Id: If9f8da55aa315296289a4062a4d69b204da99790
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/115297
Reviewed-by: Ali Zhang <alizhang@google.com>
Reviewed-by: Yecheng Zhao <zyecheng@google.com>
Reviewed-by: Ted Pudlik <tpudlik@google.com>
Reviewed-by: Rob Mohr <mohrr@google.com>
Commit-Queue: Eashan Singh <eashansingh@google.com>
When using GN as the build system, instead of running a separate
`gn gen` command to generate the compilation database, this can be done
in one step along with `pw ide cpp`. Likewise, you can generate a
compilation database directly from Ninja (or something else that
generates Ninja, like CMake) and process it in a single command.
To support all of this automatic magic, pw_ide does a lot more
work to intelligently (IMHO) infer information it needs even if it's not
provided. For example, if no target is specified and no default target
is defined in settings, we find the target with the most compilation
unit coverage. This also includes much more flexible inference of target
name from build directory structure to support more esoteric choices.
Change-Id: Ibdbeb9385a4610a3e3f1b3f80abbe672a883e0ab
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/112522
Commit-Queue: Chad Norvell <chadnorvell@google.com>
Reviewed-by: Anthony DiGirolamo <tonymd@google.com>
This adds a lifetime retry limit to the C++ and Python transfer
implementations. If the total number of retries over the duration
of the transfer exceeds this limit, the transfer is canceled. This
is done to avoid situtations where transfer could end up in an
infinite retry loop.
Change-Id: I8572a84a323e1517b7d422e6a19d094c03a88974
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/114490
Reviewed-by: Wyatt Hepler <hepler@google.com>
Commit-Queue: Alexei Frolov <frolv@google.com>
Add a blocking TODO check with exclusions for existing issues
("todo_check_with_exceptions"). Leave pre-existing "todo_check" to help
reduce the number of exceptions.
Change-Id: I8b9e01fb9cce5444fecab52d58e8ead3c0e6f65d
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/115254
Pigweed-Auto-Submit: Rob Mohr <mohrr@google.com>
Reviewed-by: Armando Montanez <amontanez@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
