Refactors Device class creation and associated argparse options to the
device_connection.py file. This allows standard Python scripts to easily
setup a connection to a device in the same way pw_system console does.
Changes to console.py:
- Remove the --proto-globs feature. This was running protoc at runtime
and on the proto files outside of the build system.
- Remove unused --output option. This is a legacy option back when
ipython was the main interface. There are already multiple logfile
creation options.
Change-Id: Icf66faf5ad7248b7e74f5087a47cb2d010e4a4fc
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/221752
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Reviewed-by: Keir Mierle <keir@google.com>
Commit-Queue: Anthony DiGirolamo <tonymd@google.com>
When downstream user is building their own protos using
pw_proto_compiler, they usually need pw_* protos alongside.
Having them handy in node_modules make it much easier.
Change-Id: Ic7650b75f15141e9c6b34586229ab4c65aeafb6b
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/222533
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Commit-Queue: Asad Memon <asadmemon@google.com>
Reviewed-by: Luis Flores <lesprit@google.com>
Because the assert macros can use format strings in some configurations,
there must not be any `%` characters within the macro argument. This
change fixes the one instance of this in pw_bluetooth_sapphire.
Change-Id: I6f00b49bfa6fa25fb78c6317e8f33dc2be19349d
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/222233
Reviewed-by: Faraaz Sareshwala <fsareshwala@google.com>
Reviewed-by: Ben Lawson <benlawson@google.com>
Commit-Queue: Jason Graffius <jgraff@google.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
This didn't always work as-is in LUCI since cwd was often not the
checkout directory.
Change-Id: Ib05247ace3d0712953cbfd5598197e400c8cbd79
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/222571
Presubmit-Verified: CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com>
Pigweed-Auto-Submit: Rob Mohr <mohrr@google.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed-service-accounts.iam.gserviceaccount.com>
Reviewed-by: Ted Pudlik <tpudlik@google.com>
These deps were provided by some transitive dependency when using the
:light backend for pw_unit_test, but are revealed as missing when
building with the :googletest backend.
Bug: 352584464
Change-Id: Id17fa7ffd36ef88321cb03f0c93342956f16abb2
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/222572
Presubmit-Verified: CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Reviewed-by: Rob Mohr <mohrr@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed-service-accounts.iam.gserviceaccount.com>
Pigweed-Auto-Submit: Ted Pudlik <tpudlik@google.com>
Adds Bazel build files to the lib/cpp-type and lib/cpp-string packages,
allowing them to be referenced from other Bazel packages within
pw_bluetooth_sapphire until the full Bazel build for
pw_bluetooth_sapphire is fully configured.
Change-Id: I920651bce3120a46e04e5fcb01506536c17e6bfe
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/222232
Reviewed-by: Faraaz Sareshwala <fsareshwala@google.com>
Reviewed-by: Ben Lawson <benlawson@google.com>
Commit-Queue: Jason Graffius <jgraff@google.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
In addition to the existing `utf8.h` header, also include all dependent
headers of `utf8.h` in the Bazel template. Additionally marks the
third_party/icu directory as a Bazel package, as otherwise Bazel will
complain when another package attempts to use icu.
Change-Id: Icc9e9fd6c758ad33682a79728da2c80d81d9c7e8
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/222231
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Reviewed-by: Faraaz Sareshwala <fsareshwala@google.com>
Pigweed-Auto-Submit: Faraaz Sareshwala <fsareshwala@google.com>
Reviewed-by: Erik Gilling <konkers@google.com>
Commit-Queue: Jason Graffius <jgraff@google.com>
Presubmit-Verified: CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Ben Lawson <benlawson@google.com>
Forgot to add a thread for the work queue.
Change-Id: I263b67ed225f74e5edccb89b62bdcbc6ae977869
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/222372
Pigweed-Auto-Submit: Wyatt Hepler <hepler@google.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Reviewed-by: Taylor Cramer <cramertj@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed-service-accounts.iam.gserviceaccount.com>
Enable dynamic allocation in pw_function, for Bazel upstream host builds
only. This has no effect on downstream projects or non-host builds.
Change-Id: Ife7eef3e13e533867c923c5c2dc9dd966f637ceb
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/221871
Reviewed-by: Erik Gilling <konkers@google.com>
Commit-Queue: Rob Mohr <mohrr@google.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Reviewed-by: Taylor Cramer <cramertj@google.com>
Commit-Queue: Ted Pudlik <tpudlik@google.com>
Changelist:
- Update icons to include play_arrow and stop
- Update light and dark styles for REPL
- Add stdin in output
- Fix scroll overflow for output
- Keep scrollbar at end when output overflows
Change-Id: I7c062c7157cf71200920a49724d4fb6f8646c2f0
Bug: 348650028
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/220971
Commit-Queue: Amy Hu <amyhu@google.com>
Reviewed-by: Luis Flores <lesprit@google.com>
Reviewed-by: Asad Memon <asadmemon@google.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Presubmit-Verified: CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com>
Remove the general exclusion of all dotfiles from the copyright notice
check. Instead, add specific files that don't support comments, like
'.bazelversion', or that are auto-generated, like '.cipd_digests'.
Bug: b/347062591
Change-Id: Ib848db7903a0acb6e28daf3039cb7b38184c6000
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/221532
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Reviewed-by: Wyatt Hepler <hepler@google.com>
Pigweed-Auto-Submit: Rob Mohr <mohrr@google.com>
Presubmit-Verified: CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed-service-accounts.iam.gserviceaccount.com>
Multiple dotfiles were caught by an internal tool as not having
appropriate copyright notices. Where possible, add copyright notices to
all dotfiles, even if not required. A followup change will remove the
exclusion that applied to these files.
Bug: b/347062591
Change-Id: Ief6fc21c1f611785e2baaa738ffc2e973e58b4bb
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/221531
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Reviewed-by: Wyatt Hepler <hepler@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed-service-accounts.iam.gserviceaccount.com>
Pigweed-Auto-Submit: Rob Mohr <mohrr@google.com>
The FakeController class has a variety of mentions of
pw::bluetooth::emboss in it. This change shorts those mentions to pwemb
using a namespace alias. This is just to make reading the code slightly
easier. There are no logic changes here.
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1006213
GitOrigin-RevId: a8f1bbcaeeb8c33ed693ce31003c0c83a7ea228b
Change-Id: I51af13463112d681f7bcddb007402b2687c4a2e2
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/221034
Commit-Queue: Auto-Submit <auto-submit@pigweed-service-accounts.iam.gserviceaccount.com>
Pigweed-Auto-Submit: Jason Graffius <jgraff@google.com>
Reviewed-by: Josh Conner <joshconner@google.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
fxrev.dev/985356 added support for extended connections. However,
somehow it got merged with only LE Enhanced Connection Complete
unmasked. It didn't get merged with LE Connection Complete unmasked. We
need to unmask LE Connection Complete so that the Controller knows to
send us the event.
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1006214
GitOrigin-RevId: e60eb09b042a745de58e9b30e419cc3075811ce8
Change-Id: I0dc43c848fa4e02f3c55f71ec722fc4bfa6e5ac3
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/221033
Reviewed-by: Josh Conner <joshconner@google.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Pigweed-Auto-Submit: Jason Graffius <jgraff@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed-service-accounts.iam.gserviceaccount.com>
Delete bt-host driver from bluetooth-core AIB base
Delete bt-host driver integration test code
Update and enable integration tests for bt-host component
fxr/959795 is merged into this CL to prevent Broadcom driver breakage
Smart Displays will now be using bt-host component after this CL
fxr/1002217 is merged into this CL to prevent Intel driver breakage
Bug: b/303116559, b/324109634
Fixed: b/326079781, b/325142183
Test:
- fx test //src/connectivity/bluetooth/
- OOBE on Nelson; paired, streamed audio to Nelson DUT from iOS device,
and disconnected
- fssh bt-snoop-cli --format pcap | wireshark -k -i -
- bt-cli start-discovery
- bt-cli list-peers
- OOBE on VIM3 hardware
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/991355
API-Review: Marie Janssen <jamuraa@google.com>
GitOrigin-RevId: 3d1f86479f0e39089fcd4de9fedc2513db0bf367
Change-Id: I7065e75faf2340250c84ffd9919b6f8b09c56dbd
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/221011
Pigweed-Auto-Submit: Jason Graffius <jgraff@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed-service-accounts.iam.gserviceaccount.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Reviewed-by: Ben Lawson <benlawson@google.com>
Implements FIDL ISO channel support in the virtual driver. This fixes
the issue during HCI initialization in integration tests where the
emulator crashes since isochronous channels weren't supported.
Other changes include: adding ISO channel handling for the bt-hci
passthrough and intel drivers, updating Banjo API name to be consistent
with FIDL.
Fixed: b/328457492, b/328459391
Test: fx test //src/connectivity/bluetooth
Manual Test: Texted with fxr/991355, paired and streamed audio to
Nelson DUT from iOS device
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1002652
API-Review: Marie Janssen <jamuraa@google.com>
GitOrigin-RevId: 5fdfa1b03e42d68e3a7dab361fc034e24f11e770
Change-Id: Id1677ee7d300be1889d7a287f6f4c966765ca349
Change-Id: I249561f58922d91b783ccc5ebbf2845bd39fbe72
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/221267
Commit-Queue: Auto-Submit <auto-submit@pigweed-service-accounts.iam.gserviceaccount.com>
Presubmit-Verified: CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com>
Pigweed-Auto-Submit: Faraaz Sareshwala <fsareshwala@google.com>
Pigweed-Auto-Submit: Jason Graffius <jgraff@google.com>
Reviewed-by: Ben Lawson <benlawson@google.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
This will improve cache hit rates, and also allow us to use
@bazel_tool//tools/cpp:link_extra_libs for pw_assert and pw_log
implementation targets (without these flags this does not work because
you invariably end up with circular dependencies).
Requires Bazel 8.
Bug: 234877642
Bug: 315871648
Change-Id: I503c501329638b666c54b8aedd0a294b8563b907
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/220812
Reviewed-by: Armando Montanez <amontanez@google.com>
Commit-Queue: Ted Pudlik <tpudlik@google.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Implement support in Banjo and FIDL controllers for ISO data
streams.
Bug: b/311639690
Test: fx test //src/connectivity/bluetooth/core/bt-host
Manual testing on Sherlock:
- OOBE
- A2DP (Source and Sink)
- HFP (AG)
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/998736
GitOrigin-RevId: e8c75890a68e5a817272737408ca399edf598674
Change-Id: I35be99c1ac152ac21780139577f29796dfaaaf5c
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/218992
Reviewed-by: Faraaz Sareshwala <fsareshwala@google.com>
Commit-Queue: Jason Graffius <jgraff@google.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
This will prevent this (quite slow) test from running as part of `bazel
test //...`. It will still be run in CI: we have a dedicated builder
that runs these tests.
Bug: 344654806
Change-Id: I18b1557beb267bb798dc2b5eb41d907bb6dd0370
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/220991
Commit-Queue: Ted Pudlik <tpudlik@google.com>
Reviewed-by: Ben Lawson <benlawson@google.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
- Move pw_system.find_serial_port interactive device selector to
pw_cli and use it for rp2040_utils.flasher.
- Add USB product and manufacturer info to the flasher selection list.
Change-Id: Iffca689dbd0e5907d330f0f6f4f7ed0d937e3605
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/220931
Reviewed-by: Taylor Cramer <cramertj@google.com>
Presubmit-Verified: CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Commit-Queue: Anthony DiGirolamo <tonymd@google.com>
Switch to using the new assert and check backends.
This is a breaking change: downstream projects now need to set the new
backend label flags (`@pigweed//pw_assert:check_backend` and
`@pigweed//pw_assert:check_backend_impl`) and include them in their link
deps.
Bug: 350585010
Change-Id: I12e70dec4c69e49dda8b1b199878b1df8d073470
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/219791
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Reviewed-by: Taylor Cramer <cramertj@google.com>
Commit-Queue: Ted Pudlik <tpudlik@google.com>
This is the first release of Bazel which includes platform-based flags.
Fix: b/344013743
Change-Id: Ia7d4327fac498e813227dedc1ef21c9ee320ac28
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/220118
Pigweed-Auto-Submit: Taylor Cramer <cramertj@google.com>
Commit-Queue: Taylor Cramer <cramertj@google.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Reviewed-by: Ted Pudlik <tpudlik@google.com>
