mirror of
https://fuchsia.googlesource.com/third_party/pigweed.googlesource.com/pigweed/pigweed
synced 2024-09-20 05:41:06 +00:00
4180d4de9a
This check verifies that the parameter names used in the function declarations and definitions match. The fix involves changing either the declaration or the definition; I chose to do one or the other on a case by case basis. My guiding principles were (1) use the same names for the same parameter in different functions in the same header, and (2) generally prefer to retain the name in the header over that in the source file (since it's more public), especially if that name also appears in a documenting comment on the function. Bug: 45 No-Docs-Update-Reason: clang-tidy change only. Change-Id: I1f1c8b421923e0ef692086138ea8df0a7d5d11c3 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/66640 Reviewed-by: Ewout van Bekkum <ewout@google.com> Commit-Queue: Ted Pudlik <tpudlik@google.com>
119 lines
3.6 KiB
YAML
119 lines
3.6 KiB
YAML
---
|
|
Checks: >
|
|
bugprone-argument-comment,
|
|
bugprone-assert-side-effect,
|
|
bugprone-bool-pointer-implicit-conversion,
|
|
bugprone-dangling-handle,
|
|
bugprone-fold-init-type,
|
|
bugprone-forward-declaration-namespace,
|
|
bugprone-inaccurate-erase,
|
|
bugprone-macro-repeated-side-effects,
|
|
bugprone-move-forwarding-reference,
|
|
bugprone-multiple-statement-macro,
|
|
bugprone-string-constructor,
|
|
bugprone-suspicious-memset-usage,
|
|
bugprone-swapped-arguments,
|
|
bugprone-undefined-memory-manipulation,
|
|
bugprone-undelegated-constructor,
|
|
bugprone-unused-raii,
|
|
bugprone-use-after-move,
|
|
clang-diagnostic-*,
|
|
-clang-analyzer-*,
|
|
darwin-avoid-spinlock,
|
|
google-build-explicit-make-pair,
|
|
google-build-namespaces,
|
|
google-default-arguments,
|
|
google-readability-function-size,
|
|
google-readability-namespace-comments,
|
|
google-runtime-operator,
|
|
misc-static-assert,
|
|
misc-unconventional-assign-operator,
|
|
misc-unused-using-decls,
|
|
modernize-*,
|
|
-modernize-avoid-c-arrays,
|
|
-modernize-concat-nested-namespaces,
|
|
-modernize-deprecated-headers,
|
|
-modernize-loop-convert,
|
|
-modernize-pass-by-value,
|
|
-modernize-raw-string-literal,
|
|
-modernize-redundant-void-arg,
|
|
-modernize-return-braced-init-list,
|
|
-modernize-unary-static-assert,
|
|
-modernize-use-auto,
|
|
-modernize-use-default-member-init,
|
|
-modernize-use-emplace,
|
|
-modernize-use-equals-default,
|
|
-modernize-use-nodiscard,
|
|
-modernize-use-override,
|
|
-modernize-use-trailing-return-type,
|
|
-modernize-use-using,
|
|
performance-faster-string-find,
|
|
performance-for-range-copy,
|
|
performance-implicit-conversion-in-loop,
|
|
performance-inefficient-algorithm,
|
|
performance-inefficient-vector-operation,
|
|
performance-move-constructor-init,
|
|
readability-container-size-empty,
|
|
readability-inconsistent-declaration-parameter-name,
|
|
readability-misleading-indentation,
|
|
readability-redundant-control-flow,
|
|
readability-redundant-smartptr-get,
|
|
readability-string-compare,
|
|
WarningsAsErrors: >
|
|
*,
|
|
-clang-diagnostic-unused-command-line-argument
|
|
HeaderFilterRegex: '.*'
|
|
...
|
|
|
|
# Disabled checks:
|
|
#
|
|
# clang-analyzer-*:
|
|
#
|
|
# performance-*
|
|
# bugprone-*
|
|
# cert-*
|
|
# misc-*
|
|
# readability-*
|
|
#
|
|
# Checks marked with @ should be reenabled first
|
|
# (the effort is minimal).
|
|
#
|
|
# modernize-avoid-c-arrays:
|
|
# @ modernize-concat-nested-namespaces:
|
|
# Note: added in c++17
|
|
# modernize-deprecated-headers:
|
|
# Advises to use <cheader> instead of <header.h> for
|
|
# legacy headers
|
|
# modernize-loop-convert:
|
|
# @ modernize-pass-by-value:
|
|
# @ modernize-raw-string-literal:
|
|
# Note: added in c++11
|
|
# @ modernize-redundant-void-arg:
|
|
# modernize-return-braced-init-list:
|
|
# @ modernize-unary-static-assert:
|
|
# Note: added in c++17
|
|
# The message argument can be omitted when it is empty
|
|
# @ modernize-use-auto:
|
|
# Advises to use auto when initializing with a cast to
|
|
# avoid duplicating the type name
|
|
# modernize-use-default-member-init:
|
|
# Note: added in c++11
|
|
# Advises to use a default initializer in
|
|
# member declarations
|
|
# @ modernize-use-emplace:
|
|
# @ modernize-use-equals-default:
|
|
# Note: added in c++11
|
|
# Advises to use '= default' for empty constructors or
|
|
# destructors '{}'
|
|
# modernize-use-nodiscard:
|
|
# Note: added in c++17
|
|
# @ modernize-use-override:
|
|
# modernize-use-trailing-return-type:
|
|
# Note: added in c++11
|
|
# Used to delay the writing of the return type
|
|
# to after the function parameters; does not make
|
|
# sense to generalise its use.
|
|
# modernize-use-using:
|
|
# Note: added in c++11
|
|
# Advises to use 'using' instead of 'typedef'
|