These checks are all fast, worthwhile, and currently pass.
Also update comment in static_analysis_toolchain.gni.
Runtime impact: On my workstation I ran,
for i in 1 2 3;
do gn clean out; gn gen out; time ninja -C out static_analysis;
done
with and without this change. The mean CPU time (user+sys) increased by
about 25%, from 559 s to 707 s. I think this is acceptable.
No-Docs-Update-Reason: We do not currently discuss in the documentation which clang-tidy checks are run for upstream pigweed itself.
Change-Id: If28652ecbd3ca6c876e6942d08d24a30717e8294
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/66440
Commit-Queue: Ted Pudlik <tpudlik@google.com>
Reviewed-by: Rob Mohr <mohrr@google.com>
Reviewed-by: Armando Montanez <amontanez@google.com>
- Implement workarounds to fix system include paths in
generated compile_commands.json files: clang-tidy is otherwise
often unable to find some system headers.
- Add basic .clang-tidy configuration
- To run the pass in pigweed presubmits:
pw presubmit --step clang_tidy
pw presubmit -p other_checks
Bug: 45
No-Docs-Update-Reason: Fix in internal API
Change-Id: I3f6cae98bfecaff86543804b28083bf304ad6a60
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/55000
Commit-Queue: Henri Chataing <henrichataing@google.com>
Reviewed-by: Wyatt Hepler <hepler@google.com>
Reviewed-by: Keir Mierle <keir@google.com>
