From e12c9358911b3b2df9720aac754e90f242613a6a Mon Sep 17 00:00:00 2001 From: Ted Pudlik Date: Fri, 28 Jun 2024 20:25:35 +0000 Subject: [PATCH] bazel: Add back to CI some building targets MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit These targets all build now and no longer need to be tagged manual. Bug: 261603269 Change-Id: I075426eb49b9eb390a12d186674ab73b234d8a9c Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/218698 Lint: Lint 🤖 Presubmit-Verified: CQ Bot Account Reviewed-by: Anthony DiGirolamo Commit-Queue: Ted Pudlik --- pw_i2c_rp2040/BUILD.bazel | 4 ---- pw_spi/BUILD.bazel | 1 + pw_spi_rp2040/BUILD.bazel | 10 +++++----- pw_sys_io_rp2040/BUILD.bazel | 2 -- 4 files changed, 6 insertions(+), 11 deletions(-) diff --git a/pw_i2c_rp2040/BUILD.bazel b/pw_i2c_rp2040/BUILD.bazel index 0e1a2b54e..e8402c772 100644 --- a/pw_i2c_rp2040/BUILD.bazel +++ b/pw_i2c_rp2040/BUILD.bazel @@ -32,8 +32,6 @@ cc_library( includes = [ "public", ], - # TODO: b/261603269 - Get this to build. - tags = ["manual"], deps = [ "//pw_chrono:system_clock", "//pw_digital_io", @@ -51,7 +49,5 @@ cc_library( pw_cc_test( name = "initiator_test", srcs = ["initiator_test.cc"], - # TODO: b/261603269 - Get this to build. - tags = ["manual"], deps = [":pw_i2c_rp2040"], ) diff --git a/pw_spi/BUILD.bazel b/pw_spi/BUILD.bazel index 227effcaf..822bffa49 100644 --- a/pw_spi/BUILD.bazel +++ b/pw_spi/BUILD.bazel @@ -65,6 +65,7 @@ cc_library( ], includes = ["public"], deps = [ + ":chip_selector", "//pw_digital_io", "//pw_status", ], diff --git a/pw_spi_rp2040/BUILD.bazel b/pw_spi_rp2040/BUILD.bazel index ad7ea6604..fdd45961f 100644 --- a/pw_spi_rp2040/BUILD.bazel +++ b/pw_spi_rp2040/BUILD.bazel @@ -32,8 +32,6 @@ cc_library( includes = [ "public", ], - # TODO: b/261603269 - Get this to build. - tags = ["manual"], deps = [ "//pw_assert", "//pw_log", @@ -48,7 +46,9 @@ cc_library( pw_cc_test( name = "initiator_test", srcs = ["initiator_test.cc"], - # TODO: b/261603269 - Get this to build. - tags = ["manual"], - deps = [":pw_spi_rp2040"], + deps = [ + ":pw_spi_rp2040", + "//pw_digital_io_rp2040", + "//pw_spi:device", + ], ) diff --git a/pw_sys_io_rp2040/BUILD.bazel b/pw_sys_io_rp2040/BUILD.bazel index aebec87c0..4771c8fb1 100644 --- a/pw_sys_io_rp2040/BUILD.bazel +++ b/pw_sys_io_rp2040/BUILD.bazel @@ -26,8 +26,6 @@ cc_library( srcs = [ "sys_io.cc", ], - # TODO: b/261603269 - Get this to build. - tags = ["manual"], deps = [ "//pw_status", "//pw_sync:thread_notification",