From 1dbd4a434d58ba823c9744bebb20b9b521b09028 Mon Sep 17 00:00:00 2001
From: Taylor Cramer <cramertj@google.com>
Date: Wed, 26 Jun 2024 18:25:45 +0000
Subject: [PATCH] pw_presubmit: Add check for rp2040_binary transition
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Change-Id: Ie6de3159296382bcd7077184d5b2d54bd7a3e252
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/218273
Pigweed-Auto-Submit: Taylor Cramer <cramertj@google.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Reviewed-by: Armando Montanez <amontanez@google.com>
Commit-Queue: Taylor Cramer <cramertj@google.com>
---
 pw_presubmit/py/pw_presubmit/pigweed_presubmit.py | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/pw_presubmit/py/pw_presubmit/pigweed_presubmit.py b/pw_presubmit/py/pw_presubmit/pigweed_presubmit.py
index ac0251beb..af1229230 100755
--- a/pw_presubmit/py/pw_presubmit/pigweed_presubmit.py
+++ b/pw_presubmit/py/pw_presubmit/pigweed_presubmit.py
@@ -869,6 +869,7 @@ def bazel_build(ctx: PresubmitContext) -> None:
     )
 
     # Build upstream Pigweed for the rp2040.
+    # First using the config.
     build_bazel(
         ctx,
         'build',
@@ -881,6 +882,15 @@ def bazel_build(ctx: PresubmitContext) -> None:
         # will return an error instead of skipping it.)
         '//pw_system:system_example',
     )
+    # Then using the transition.
+    #
+    # This ensures that the rp2040_binary rule transition includes all required
+    # backends.
+    build_bazel(
+        ctx,
+        'build',
+        '//pw_system:rp2040_system_example',
+    )
 
     # Build upstream Pigweed for the Discovery board using STM32Cube.
     build_bazel(